-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up release notes for 0.9.1 #232
Conversation
Signed-off-by: Leandro Lucarella <[email protected]>
## Summary | ||
|
||
<!-- Here goes a general summary of what this release is about --> | ||
|
||
## Upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you want to remove the headings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes (empty headings in the release notes are just noise and confusing IMHO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you're keeping the "Bug fixes" heading. And in the SDK you're keeping all the headings. Maybe nice to follow a more predictable pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and bug fixes has an entry under it that wasn't cleaned up. is that supposed to be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always try to remove all empty headings, if that's not the case, it's a bug. I'm keeping the bug fixes header because it is not empty. I'm starting to think you believe this is a release notes cleaning after a release, but this one is cleaning the notes to make a release after it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, I thought it was after. Then it makes sense.
No description provided.