Fix Markdown type:ignore #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:template
|
Based on: |
Marenz
reviewed
Apr 16, 2024
| -e '/# `slugify_unicode` function, but it definitely does./d' \ | ||
| docs/_scripts/macros.py | ||
| echo | ||
| manual_step "Please make sure that the 'Markdown' and 'types-Markdown' dependencies are at version 3.5.2 or higher in 'pyproject.toml':" |
There was a problem hiding this comment.
Why must this be a manual step?
There was a problem hiding this comment.
Because it is too time consuming and complicated to make it automatic, I just wanted to strike a good balance to still have time to do other stuff that has more priority than this 🤷
Marenz
reviewed
Apr 16, 2024
It sounds quite time consuming to me, parsing python versions properly is tricky, and updating the |
|
For me it was a "get 90% of the benefits doing 10% of the work" kind of thing. |
The new version solves a typing issue we needed to ignore in the past. Using the fixed version as the minimum avoid problems when upgrading the `Markdown` in new projects. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
|
Rebased and enabled auto-merge. |
llucax
added
part:tooling
Marenz
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.