Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the nox-cross-arch-all job if any matrix job fails #261

Merged
merged 1 commit into from
May 3, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented May 3, 2024

Otherwise this job will be skipped, just like when the matrix jobs are skipped, resulting in a passed check when it should have failed.

@llucax llucax requested a review from a team as a code owner May 3, 2024 09:25
@llucax llucax self-assigned this May 3, 2024
@github-actions github-actions bot added the part:template Affects the cookiecutter template files label May 3, 2024
@llucax llucax added this to the v0.10.0 milestone May 3, 2024
@llucax llucax enabled auto-merge May 3, 2024 09:26
@llucax llucax added type:bug Something isn't working part:ci Affects the GitHub workflow and other parts for running CI labels May 3, 2024
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a cosmetic to check for and LGTM

@llucax llucax force-pushed the fix-cross-arch branch 2 times, most recently from ebf365e to dec2ab3 Compare May 3, 2024 10:26
Otherwise this job will be skipped, just like when the matrix jobs are
skipped, resulting in a passed check when it should have failed.

Co-authored-by: daniel-zullo-frequenz <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax force-pushed the fix-cross-arch branch from dec2ab3 to 385cc4e Compare May 3, 2024 10:29
@llucax
Copy link
Contributor Author

llucax commented May 3, 2024

I fixed the comment in the template and migration script, so it needs another approval.

@llucax llucax added this pull request to the merge queue May 3, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit d0775e4 May 3, 2024
14 checks passed
@llucax llucax deleted the fix-cross-arch branch May 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:ci Affects the GitHub workflow and other parts for running CI part:template Affects the cookiecutter template files type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants