Pin sybil to < 6.1 #262
Merged
Pin sybil to < 6.1 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tooling
daniel-zullo-frequenz
previously approved these changes
May 3, 2024
Sybil 6.1.0 fixes a bug which we thought it was proper behavior, so upgrading to it would break our tests. This is a temporary workaround until we fix our code to work with the new sybil version. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
|
There is something funny going on with branch protection using rulesets, now this PR got merged even if the tests were failing. I pushed a fix but what was merged was the unfixed versions. Not sure if we hit a race condition or what but I have been observing a lot of weird behavior with PRs being merged when merge queue tests failed and now this, which should have not been queued at all. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 3, 2024
Should have been part of #262.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround until #249 is fixed.