Fix the Queue PRs for v0.x.x.json ruleset #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ruleset now matches the requirements of the `Protect version branches` ruleset, including all CI checks that must pass. Without this, the queued PRs were merged even if the checks failed. This sadly introduces some redundancy, but we can't use only one rule if we want the main rule to use wildcards, so all new version branches are protected by default. Signed-off-by: Leandro Lucarella <[email protected]>
daniel-zullo-frequenz
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ruleset now matches the requirements of the
Protect version branchesruleset, including all CI checks that must pass.Without this, the queued PRs were merged even if the checks failed.
This sadly introduces some redundancy, but we can't use only one rule if we want the main rule to use wildcards, so all new version branches are protected by default.