Fix the condition to run the nox-cross-arch-all job
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:ci
llucax
force-pushed
the
fix-cross-arch
branch
11 times, most recently
from
9f4f9c8 to
91132ff
Compare
github-actions
bot
added
the
part:template
llucax
added
the
cmd:skip-release-notes
|
Skipping release notes because the previous release notes are enough. |
|
I tested this quite a bit in this PR, simulation skips, failures and successes, I hope it is really working properly now. |
Marenz
previously approved these changes
May 6, 2024
Signed-off-by: Leandro Lucarella <[email protected]>
The current condition makes the job skip unless there is a failure, which means we also skip on success, which is not right, as we want this job to succeed if the matrix job succeeds. To fix this, we only skip if the `nox-cross-arch` matrix job was skipped and we run otherwise, failing the job if the matrix job was not successful. We also use the job name explicitly, as we only have one dependency and it is easier to reason about a string than about arrays. Signed-off-by: Leandro Lucarella <[email protected]>
|
Fixed the quoting style in the |
Marenz
previously approved these changes
May 6, 2024
Even when this is not necessary for now, as we are not skipping jobs in the `nox` matrix job, it's better to have a consistent behavior to avoid surprises in the future. Signed-off-by: Leandro Lucarella <[email protected]>
|
Damn, one golden test was not properly updated. Now it is green, but news a new approval 🙏 |
Marenz
approved these changes
May 6, 2024
github-merge-queue bot
pushed a commit
to frequenz-floss/frequenz-client-base-python
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current condition makes the job skip unless there is a failure, which means we also skip on success, which is not right, as we want this job to succeed if the matrix job succeeds.
To fix this, we only skip if the
nox-cross-archmatrix job was skipped and we run otherwise, failing the job if the matrix job was not successful. We also use the job name explicitly, as we only have one dependency and it is easier to reason about a string than about arrays.For consistency reasons, and to avoid future surprises, we also make the
nox-alljob run on failures of its child jobs, even when it is not necessary for now as we are not skipping jobs in thenoxmatrix job.