Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asyncio_default_fixture_loop_scope = "function" option #318

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Oct 1, 2024

pytest-asyncio has deprecated not providing a value for the asyncio_default_fixture_loop_scope option. This commit adds a default value of "function" for this option, as it was the previous default, in the pyproject.toml files of this and all the generated projects.

@llucax llucax requested a review from a team as a code owner October 1, 2024 08:05
@llucax llucax self-assigned this Oct 1, 2024
@llucax llucax enabled auto-merge October 1, 2024 08:05
@github-actions github-actions bot added the part:template Affects the cookiecutter template files label Oct 1, 2024
@llucax llucax added type:tech-debt Improves the project without visible changes for users part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Oct 1, 2024
@llucax llucax added this to the v0.11.0 milestone Oct 1, 2024
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pyproject.toml Outdated Show resolved Hide resolved
`pytest-asyncio` has deprecated not providing a value for the
`asyncio_default_fixture_loop_scope` option. This commit adds a default
value of `"function"` for this option, as it was the previous default,
in the `pyproject.toml` files of this and all the generated projects.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax added this pull request to the merge queue Oct 25, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 0adfc17 Oct 25, 2024
14 checks passed
@llucax llucax deleted the pytest branch October 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:template Affects the cookiecutter template files part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:tech-debt Improves the project without visible changes for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants