Merge pull request #1020 from nupplaphil/bug/9142-message-id

[phpmailer] Fixes Double Message ID
friendica · Sep 20, 2020 · 10d1156 · 10d1156
2 parents a2328af + 5663e61
commit 10d1156
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/phpmailer/phpmailer.php b/phpmailer/phpmailer.php
@@ -90,9 +90,14 @@ function phpmailer_emailer_send_prepare(App $a, IEmail &$email)
 
 		// additional headers
 		if (!empty($email->getAdditionalMailHeader())) {
-			foreach (explode("\n", trim($email->getAdditionalMailHeader())) as $header_line) {
-				list($name, $value) = explode(':', $header_line, 2);
-				$mailer->addCustomHeader(trim($name), trim($value));
+			foreach ($email->getAdditionalMailHeader() as $name => $values) {
+				// Set the "Message-ID" header for PHP-Mailer directly
+				if ($name == 'Message-Id') {
+					// implode all values to one entry, because there's only one value possible
+					$mailer->MessageID = trim(implode("", $values));
+				} else {
+					$mailer->addCustomHeader(trim($name), trim(implode("\n", $values)));
+				}
 			}
 		}
 

diff --git a/securemail/SecureTestEmail.php b/securemail/SecureTestEmail.php
@@ -54,6 +54,6 @@ public function __construct(App $a, IConfig $config, IPConfig $pConfig, BaseURL
 
 		parent::__construct($sitename, $sender_email, $sender_email, $a->user['email'],
 			$subject, "<p>{$message}</p>", $message,
-			'', local_user());
+			[], local_user());
 	}
 }