Store management with createStore

[fahad19]

What's done

• New createStore function
  • Used internally for handling Stores for App instances
• Dropped redux
• Fully backwards compatible with deprecated methods
• Full test coverage
• Minified/gzipped dist file down to ~7kB from ~13kB

Preview

Both examples in the repo working, and here's a screenshot for Multiple Widgets:

[coveralls]

Coverage remained the same at 100.0% when pulling 66548ea on store into e61aa26 on master.

[coveralls]

Coverage remained the same at 100.0% when pulling 70acc5c on store into 1ccbc12 on master.

[mAiNiNfEcTiOn]

Remember, you don't have zero-padded integers.

[mAiNiNfEcTiOn]

Perhaps this logic should go to the logger itself, or better yet, whenever you create an instance of the logger you could specify the environment(s) in which it should work?

Why? Because of this: nodejs/node#3104

Another way would be to cache that value at the beginning of the module. :)

[fahad19]

@mAiNiNfEcTiOn: I kept it like it was working before. The main reason is because of our production bundles.

When NODE_ENV === production, the full code-block inside this if would not end up in the bundle processed by Webpack (in our case, it is vendors.js file).

If we want to check it in runtime instead, it means the logger specific code would have to be in the bundle all the time. Do we want that in this PR?

Please correct me if I understood your comment wrong.

[mAiNiNfEcTiOn]

Ok, clear then.

[mAiNiNfEcTiOn]

Is this action the String (e.g. 'MY_ACTION') or the Object passed with the type?

[fahad19]

@mAiNiNfEcTiOn: sorry for the confusion. I should add some docblocks soon.

Store.dispatch can accept:

• a payload, like: {type: 'DO_SOMETHING'}, or
• a function, like:

  function (dispatch, getState, { app }) {
    aTimeConsumingPromise()
      .then(function () {
        dispatch({ type: 'DO_SOMETHING' });
      });
  }

It maintains the sync/async actions, just like how we support them now.

[mAiNiNfEcTiOn]

;) Sure... good good. That's ok then :) 👍

[markvincze]

The couple of deleted test files, like appendAction, and async: why aren those not needed anymore?

And just to make sure I understand correctly: instead of depending on redux, you implemented a small part of its functionality in createStore.js?

[fahad19]

@markvincze: they are deleted because they were middlewares for Redux, now they are supported directly via createStore function, in the form of passed options.

See these options in createStore.js:

• thunkArgument: for deleted async.js middleware
• appendAction: for deleted appendAction.js middleware
• enableLogger: for deleted logger.js middleware

[coveralls]

Coverage remained the same at 100.0% when pulling d72a158 on store into 1ccbc12 on master.

[mAiNiNfEcTiOn]

-.-' One liners...:

((str) => '0'.repeat(Math.abs(str.length - 2)) + str)(d.getHours())...

But what do I know? 😄