Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregateRowsBy in Issue 375 #408

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Fix aggregateRowsBy in Issue 375 #408

merged 1 commit into from
Aug 8, 2018

Conversation

zyzhu
Copy link
Contributor

@zyzhu zyzhu commented Aug 8, 2018

Attempt to fix #375

  1. Get all values of groupBy including missing values
  2. Added test
sample:
     A         B C 
1 -> 10        1 1 
2 -> <missing> 2 2 
3 -> 10        1 3 
4 -> <missing> 2 4 
5 -> 10        3 5

operation:
sample |> Frame.aggregateRowsBy ["A";"B"] ["C"] Stats.mean

expected:
     A         B C 
0 -> 10        1 2 
1 -> <missing> 2 3 
2 -> 10        3 5

@zyzhu zyzhu merged commit c07d8d9 into fslaborg:master Aug 8, 2018
@zyzhu zyzhu deleted the issue-375 branch August 9, 2018 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspicious result of AggregateRowsBy
1 participant