New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change of Stats.min and Stats.max #422

Merged

zyzhu merged 2 commits into fslaborg:master from zyzhu:issue-419

Aug 14, 2018

Contributor

zyzhu commented Aug 14, 2018

To address issue #419

Renamed original min/max functions to tryMin/tryMax
Added new min/max functions that output Double.NaN. I figure all other inline functions essentially converted integer to float in output. It's ok to have Stats.min and Stats.max output float as well. User can convert it back to int if they really want to stick to the original type. This design is still easier to use than the original optional values.

zyzhu added 2 commits

August 14, 2018 16:20


          changed min/max to tryMin/tryMax. added min/max that outputs nan

290610c


          refactored describe function to use new min/max function

6ba06fd

zyzhu merged commit dd2c2ca into fslaborg:master

zyzhu mentioned this pull request

Optional output of Stats.min and Stats.max on series #419

Closed

zyzhu deleted the issue-419 branch

August 14, 2018 20:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet