New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointwise parameter in frame1.zip #434

Merged

zyzhu merged 2 commits into fslaborg:master from zyzhu:issue-432

Aug 21, 2018

Contributor

zyzhu commented Aug 21, 2018

To address #432

Added pointwise parameter in frame1.zip. If false, the unmatched column will be missing. If true, the column will be left unchanged.
Adjusted PointwiseFrameFrame to call frame1.zip with pointwise set to be true
Adjusted zipAlign with pointwise set to be false to keep the original behavior
Added unit test

zyzhu added 2 commits

August 21, 2018 07:16


          added pointwise parameter in frame1.zip for arithmetic operators

7f13197


          adjusted unit test and function comments

dca3709

zyzhu merged commit a62e514 into fslaborg:master

zyzhu mentioned this pull request

Arithmetic operator on frames shows unexpected result #432

Closed

zyzhu deleted the issue-432 branch

August 22, 2018 16:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet