Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise IndexOutOfRangeException warning when accessing empty series by index #437

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Raise IndexOutOfRangeException warning when accessing empty series by index #437

merged 2 commits into from
Aug 21, 2018

Conversation

zyzhu
Copy link
Contributor

@zyzhu zyzhu commented Aug 21, 2018

To address #365

@alexpantyukhin
Copy link
Contributor

For example for the method Get I think that there is no need to check that series is empty. Because in common, anyway it means missingVal. What do you think?

@zyzhu
Copy link
Contributor Author

zyzhu commented Aug 21, 2018

You are right. IndexOutOfRangeException shall just be raised for accessing by index only. I'll simplify it.

@zyzhu zyzhu changed the title Raise IndexOutOfRangeException warning when accessing empty series Raise IndexOutOfRangeException warning when accessing empty series by index Aug 21, 2018
@zyzhu zyzhu merged commit 02e1a90 into fslaborg:master Aug 21, 2018
@zyzhu zyzhu mentioned this pull request Aug 21, 2018
Closed
@zyzhu zyzhu deleted the issue-365 branch August 22, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyzhu @alexpantyukhin