-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest NetOffice Excel package #505
Conversation
I had a look at the migration notice here: https://netoffice.io/migrate-notice/. Is this saying that the original versions have been hacked? For an outsider, it is quite hard to tell what's going on here. Can you please add a bit more background about this? Were you the maintainer of the "netoffice" versions of the packages but somehow lost access to those? If so, wouldn't NuGet administrators be able to restore that? Looking at your recent work on the project, it is clear to see that you are actively working on the project, but changing the NuGet package name sounds like an extreme measure. |
Original code author of NetOffice is Sebastian. He developed the code on Codeplex and moved the code to OSDN. He did not want to move to GitHub but he approved I can make mirror at https://github.com/NetOfficeFw (see https://archive.codeplex.com/?p=netoffice - the Project has moved to section) On GitHub, the @netoffice organization was already taken by somebody and the person was not communicating with Sebastian nor me. To publish latest NetOffice code (from OSDN) I had to choose a new name for nuget packages. I chose NetOfficeFw. You can check manually that assemblies published at https://osdn.net/projects/netoffice/releases/ are the same binaries I published in https://www.nuget.org/packages/NetOfficeFw.Excel/1.7.4.3 When Sebastian published the NetOffice 1.7.4.3, suddenly somebody from @netoffice published NetOffice.Excel 1.7.4.4 (one version higher, yet at the time, no such official NetOffice release was made) Meanwhile, Sebastian is not working on NetOffice anymore and I was occasionally fixing small bugs. Releases from @NetOfficeFw organization are signed by authenticode certificate so you can check you get original nuget packages and also assemblies. Two days ago, @erikaleblanc88 published other NetOffice.Excel packages - version 1.7.4.11. That package contains old and modified NetOffice assemblies. I am not sure why @augustoproiete gave her access to the https://github.com/netoffice/NetOffice-NuGet repository. I am sorry for this trouble but this rogue release of NetOffice.Excel really upset me and I had to do something. I see you are using NetOffice for a good cause and I would like you to use the correct code. That's why I made the PR. PS: I contacted NuGet and GitHub numerous times, but unfortunately they cannot do anything. |
Thank you so much @jozefizso for the explanation. To provide more background, I also received the following email from @erikaleblanc88:
... which is why I'm trying to figure out what is going on! It seems that the version maintained by @jozefizso is the more active recent one. One thing I still do not understand is who has been releasing the NuGet packages |
I'm really sorry for this, I did not want you to be taken into such politics and in intrigues. Regarding the email, I have only this to say: Here is my official request about moving forward with the NetOffice project: https://web.archive.org/web/20170913124442/https://github.com/netoffice/NetOffice/issues/3 At later time, he just deleted everything: https://web.archive.org/web/20181107215735/https://github.com/netoffice/NetOffice/issues/3 It's sad they are trying to ruin the project. I'm signing the code with my personal GPG key and signing the assemblies and nuget packages with my certificates. It's the best I can do to ensure the trust (especially in this complicated fork and project migration). And I'm denying all the accusations of Erika. |
Latest |
@jozefizso thank you very much for providing all those details and extra evidence! As you can probably guess, it's very hard to see what's going on for an outsider, so your replies have been invaluable in clarifying this. Thank you for your hard work on maintaining NetOffice! @zyzhu As long as you are also happy with the explanation, I think we should merge the PR. |
@tpetricek Thanks for looking into this. @jozefizso Thanks for the detailed explanation. The CI documentation test failure is due to World Bank API change. |
Update Excel package to 1.7.4.11
PS: Packages are changed to the NetOfficeFw because those contain the latest code.