allow "IN" Expression to have a list or a set as a parameter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is because for values like Int64 passing an array to an IN expression is not allowed and requires variadic parameter
|
I added the tests and updated the README file as requested to cover the new "IN" functions. |
ftchirou
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Thank you for the updates. The code coverage went down. I added a suggestion to fix that and another suggestion for the README.
|
Thank you @ftchirou for your suggestions. I tried to follow them as close as possible to what you mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is because for values like Int64 passing an array to an IN expression is not allowed and requires variadic parameter