Don't run clippy on bindgen files. Added all the lints for build.rs.
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newAM
requested changes
Aug 24, 2024
src/lib.rs
Outdated
Comment on lines
3
to
7
| future_incompatible, | ||
| non_camel_case_types, | ||
| non_snake_case, | ||
| non_upper_case_globals, | ||
| unsafe_code |
There was a problem hiding this comment.
The 0.70.1 release fixed some of these, can you update it?
|
Grinkers@d016cc4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help #76
This is just allowing all clippy lints of generated code, as there's no point in linting bindgen. There's not much code in build.rs, so I just added all the lints and did the appropriate fixes.
You can see it properly failing here
Grinkers@fe8ef33
Passing with the newest bindgen
Grinkers@5eab029