feat: Backlog/framework loader nuke #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
lluisCM
commented
Jul 12, 2024
| @@ -7,6 +7,11 @@ | |||
| from functools import partial | |||
| import platform | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
Comment from Mattias:
mlagergren 2 weeks ago
Why this change?
| if store.get('is_sequence'): | ||
| # Expect path to be on the form folder/plate.%d.exr [1-35], convert to Nuke loadable | ||
| # format | ||
| sequence_metadata = check_image_sequence(image_path) |
There was a problem hiding this comment.
Use clique instead
|
|
||
| import nuke | ||
|
|
||
| from ftrack_utils.paths import check_image_sequence |
There was a problem hiding this comment.
Use clique instead
lluisCM
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves :
This PR has been tested on :
Overview
Purpose: Nuke implementation of the loader
Scope: framework-nuke
Implementation Details
Approach:
Reasoning:
Changes:
Trade-offs:
Testing
Tests Added:
Manual Testing:
Testing Environment:
Notes for Reviewers
Focus Areas:
Dependencies:
Known Issues: