Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Provide proper fallback when icon not found #606

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: Provide proper fallback when icon not found #606

merged 2 commits into from
Dec 12, 2024

Conversation

dennisweil
Copy link
Contributor

@dennisweil dennisweil commented Dec 10, 2024 •
edited
Loading

Resolves :

  • CLICKUP-
  • FT-
  • SENTRY-
  • ZENDESK-
  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains update to the release notes.
  • The PR contains update to the documentation.

This PR has been tested on :

  • Windows.
  • MacOs.
  • Linux.

Overview

Purpose:

Scope:

Implementation Details

Approach:

Reasoning:

Changes:

Trade-offs:

Testing

Tests Added:

Manual Testing:

Testing Environment:

Notes for Reviewers

Focus Areas:

Dependencies:

Known Issues:

@dennisweil dennisweil requested a review from a team as a code owner December 10, 2024 13:53
lluisCM
lluisCM reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@lluisCM lluisCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok as a temporal fix. Can you update the connect version to 24.11.1? Thanks.

@dennisweil
Use default icon when icon not found
0d79862 
Connect context selector will now fall back
to a default icon when the requested icon cannot
be found. This prevents craching.
@dennisweil dennisweil merged commit 0ef8ea9 into release/24.11.0 Dec 12, 2024
2 checks passed
@dennisweil dennisweil deleted the backlog/fix-24.11.0-context-selector-icon-not-found branch December 12, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lluisCM lluisCM lluisCM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisweil @lluisCM