build: add cmake support for qt6 #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndrII
suggested changes
Dec 29, 2021
features: - add option to specify target qt version - dynamically locate QT version and use version specific components and linker targets (also see https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html#supporting-older-qt-5-versions) fixes: - revert minimum required cmake version to 3.2 (was incremented accidentally in commit ebb3e5e) - remove duplicate compile definitions for 1D barcode support - include qt components multimedia, svg, quick and quickcontrols2 only when neccessary
dabbinavo
force-pushed
the
feature/qt6-cmake-support
branch
from
3045477 to
0b1fbbe
Compare
EndrII
reviewed
Dec 29, 2021
EndrII
approved these changes
Dec 29, 2021
@EndrII, what do you mean by "can't check build manually" I successfully build the library for Qt5.15.2 and Qt6.2.2 with the following settings (total of 4 builds): Build A cmake_minimum_required(VERSION 3.2)
project(test)
SET(QZXING_MULTIMEDIA ON)
SET(QZXING_USE_DECODER_1D_BARCODES ON)
SET(QZXING_USE_DECODER_QR_CODE ON)
add_subdirectory(ext/qzxing/src)Build B cmake_minimum_required(VERSION 3.2)
project(test)
SET(QZXING_USE_ENCODER ON)
add_subdirectory(ext/qzxing/src) |
|
Where are BOSS of this project ?) |
|
@ftylitak anything missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features:
fixes: