Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: Support building as shared library (as one would need… #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunweaver
Copy link

… for packaging a DEB package).

)

install (
FILES ${PUBLIC_HEADERS} DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/qzxing"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The QMake build installs the headers into the equivalent of just CMAKE_INSTALL_INCLUDEDIR. Could we make the install locations match to avoid differences between QMake & CMake being used for the build?

/nix/store/vyqb9vi69yrkmg4j1rw5vsd7rhfq7f5c-qzxing-3.3.0
├── include
│   ├── QZXing_global.h
│   └── QZXing.h
└── lib
    ├── libQZXing.so -> libQZXing.so.3.3.0
    ├── libQZXing.so.3 -> libQZXing.so.3.3.0
    ├── libQZXing.so.3.3 -> libQZXing.so.3.3.0
    ├── libQZXing.so.3.3.0
    └── pkgconfig
        └── QZXing.pc
Suggested change
FILES ${PUBLIC_HEADERS} DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/qzxing"
FILES ${PUBLIC_HEADERS} DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants