Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: unpack #11

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

WIP: unpack #11

wants to merge 11 commits into from

Conversation

fabianfreyer
Copy link
Contributor

No description provided.

@fabianfreyer fabianfreyer added enhancement New feature or request do-not-merge DO not merge labels Aug 9, 2019
@fabianfreyer fabianfreyer self-assigned this Aug 9, 2019
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #11   +/-   ##
======================================
  Coverage    86.3%   86.3%           
======================================
  Files           6       6           
  Lines         336     336           
======================================
  Hits          290     290           
  Misses         46      46
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b74d8...e80d39c. Read the comment docs.

@fabianfreyer fabianfreyer requested a review from gronke August 11, 2019 23:24
@fabianfreyer
Copy link
Contributor Author

@gronke could you take a look at the check_path_in function? I'd appreciate a second pair of eyes on this, as it's security critical that no .. can be smuggled past that to delete files outside of the container root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge DO not merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant