Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial ImageStorage trait. #15

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

fabianfreyer
Copy link
Contributor

Build an ImageStorage trait, and implement it for the Registry. Make everything else using the Registry directly reference this instead.

  • Add the trait
  • Implement for Repository.
  • Change Image to use the trait, probably using a Box<dyn ImageStorage> inside, or something like it.

@fabianfreyer fabianfreyer added the enhancement New feature or request label Aug 22, 2019
@fabianfreyer fabianfreyer added this to the MVP milestone Aug 22, 2019
@fabianfreyer fabianfreyer requested a review from sashakm August 22, 2019 00:50
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #15 into master will decrease coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage    86.3%   84.54%   -1.77%     
==========================================
  Files           6        6              
  Lines         336      343       +7     
==========================================
  Hits          290      290              
- Misses         46       53       +7
Impacted Files Coverage Δ
src/image/go.rs 57.89% <0%> (-2.11%) ⬇️
src/image/manifest.rs 88.88% <0%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b74d8...ab2c15d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants