Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deedName(), change visibility of ownerOf() and countOfDeeds() #1

Closed
wants to merge 2 commits into from
Closed

Remove deedName(), change visibility of ownerOf() and countOfDeeds() #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a50fe8
Remove deedName()
Nanolucas Feb 5, 2018
4b9eec5
Change ownerOf() and countOfDeeds() to public
Nanolucas Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions EIPS/eip-721.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ interface ERC721 {
/// queries about them do throw.
/// @return The non-zero address of the owner of deed `_deedId`, or `throw`
/// if deed `_deedId` is not tracked by this contract
function ownerOf(uint256 _deedId) external view returns (address _owner);
function ownerOf(uint256 _deedId) public view returns (address _owner);

/// @notice Count deeds tracked by this contract
/// @return A count of valid deeds tracked by this contract, where each one of
/// them has an assigned and queryable owner not equal to the zero address
function countOfDeeds() external view returns (uint256 _count);
function countOfDeeds() public view returns (uint256 _count);

/// @notice Count all deeds assigned to an owner
/// @dev Throws if `_owner` is the zero address, representing invalid deeds.
Expand Down Expand Up @@ -155,10 +155,6 @@ interface ERC721Metadata {
/// @dev Wallets and exchanges MAY display this to the end user.
function symbol() public pure returns (string _symbol);

/// @notice A distinct name for a deed managed by this contract
/// @dev Wallets and exchanges MAY display this to the end user.
function deedName(uint256 _deedId) public pure returns (string _deedName);

/// @notice A distinct URI (RFC 3986) for a given token.
/// @dev If:
/// * The URI is a URL
Expand Down