Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technical task]: Refactor the code to support unit test #86

Open
axel3rd opened this issue Dec 17, 2021 · 2 comments · Fixed by axel3rd/log4j-scan#1 · May be fixed by #95
Open

[Technical task]: Refactor the code to support unit test #86

axel3rd opened this issue Dec 17, 2021 · 2 comments · Fixed by axel3rd/log4j-scan#1 · May be fixed by #95

Comments

@axel3rd
Copy link
Contributor

axel3rd commented Dec 17, 2021

For some feature implementation, I tried to implement unit tests, to have the capability to check request content with Pytest and adapter = requests_mock.get('https://localhost/').

Currently, it is quite complicated mainly due to:

  • - in script name
  • argument parsing & some concrete code outside the main function

=> Is it possible to "coordinate" this refactor to achieve that (all current PRs should be updated with this kind of change => it should be done after accepting all the relevant).

@axel3rd
Copy link
Contributor Author

axel3rd commented Dec 22, 2021

tests/

@mazen160 : I'm surprised by that 😬. Are there already some existing tests (locally?) ?

@axel3rd
Copy link
Contributor Author

axel3rd commented Dec 23, 2021

Reopen for merge in original repo.

Testable from https://github.com/axel3rd/log4j-scan

@axel3rd axel3rd reopened this Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant