-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Technical task]: Refactor the code to support unit test #86
Open
axel3rd opened this issue
Dec 17, 2021
· 2 comments
· Fixed by axel3rd/log4j-scan#1 · May be fixed by #95
Open
[Technical task]: Refactor the code to support unit test #86
axel3rd opened this issue
Dec 17, 2021
· 2 comments
· Fixed by axel3rd/log4j-scan#1 · May be fixed by #95
Comments
Reopen for merge in original repo. Testable from https://github.com/axel3rd/log4j-scan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For some feature implementation, I tried to implement unit tests, to have the capability to check request content with Pytest and
adapter = requests_mock.get('https://localhost/')
.Currently, it is quite complicated mainly due to:
-
in script name=> Is it possible to "coordinate" this refactor to achieve that (all current PRs should be updated with this kind of change => it should be done after accepting all the relevant).
The text was updated successfully, but these errors were encountered: