Remove redundant custom chunk preloading code

fusionjs · Jul 27, 2018 · 135eb76 · 135eb76
1 parent c6a6459
commit 135eb76
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 80 deletions.
diff --git a/build/chunk-preload-plugin.js b/build/chunk-preload-plugin.js
diff --git a/build/compiler.js b/build/compiler.js
@@ -27,7 +27,6 @@ const resolveFrom = require('resolve-from');
 const AssetsManifestPlugin = require('@nadiia/file-loader')
   .assetsManifestPlugin;
 const ClientSourceMapPlugin = require('./client-source-map-plugin');
-const ChunkPreloadPlugin = require('./chunk-preload-plugin');
 const ChunkModuleManifestPlugin = require('./chunk-module-manifest-plugin');
 const chunkModuleManifest = require('./chunk-module-manifest');
 const InstrumentedImportDependencyTemplatePlugin = require('./instrumented-import-dependency-template-plugin');
@@ -448,9 +447,6 @@ function getConfig({target, env, dir, watch, cover}) {
       env === 'production' &&
         target === 'web' &&
         new webpack.HashedModuleIdsPlugin(),
-      target === 'web' && env !== 'test' && new ChunkPreloadPlugin(),
-      // TODO(#11): What do we do for client-side error reporting in the service worker?
-      // Do we add in reporting code to the sw? Should we map stack traces on the server?
       target === 'web' && new ClientSourceMapPlugin(),
       target === 'web' && new SyncChunkIdsPlugin(),
       target === 'web' &&

diff --git a/test/cli/build.js b/test/cli/build.js
@@ -205,15 +205,15 @@ test('`fusion build` app with dynamic imports integration', async t => {
   );
   t.equal(
     await page.$$eval('script', els => els.length),
-    6,
-    'should be 6 scripts'
+    5,
+    'should be 5 scripts'
   );
   await page.click('#split-route-link');
 
   t.equal(
     await page.$$eval('script', els => els.length),
-    7,
-    'should be 7 scripts after dynamic loading'
+    6,
+    'should be 6 scripts after dynamic loading'
   );
 
   t.ok(