This repository has been archived by the owner on May 17, 2019. It is now read-only.
Make react/enzyme dependency soft #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add one of the following required labels:
|
1 similar comment
|
Please add one of the following required labels:
|
KevinGrandon
previously approved these changes
Aug 15, 2018
| @@ -8,15 +8,7 @@ | |||
|
|
|||
| /* eslint-env node */ | |||
|
|
|||
| const React = require('react'); | |||
| const RedBox = require('redbox-react').RedBoxError; | |||
There was a problem hiding this comment.
If we're getting rid of this, we should remove the redbox-react dependency from package.json
|
Please add one of the following required labels:
|
KevinGrandon
previously approved these changes
Aug 15, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fusion-cli depends on react and enzyme in order to be used at all. This was originally done to make it easier to test React, but the overall goal of fusion-cli is to be a CLI+compilation infrastructure that is agnostic of view libraries.
This PR allows fusion-cli to be installed and used without throwing react/enzyme-related errors, while still enabling them to be used if they're detected.