Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.xml #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update strings.xml #107

wants to merge 1 commit into from

Conversation

McIrco95
Copy link

@McIrco95 McIrco95 commented Oct 27, 2023

DE Translation

Copy link

@Bluscream Bluscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tom-futo tom-futo closed this Dec 10, 2024
@futo-cla-pr-labler
Copy link

Please sign our contributor license agreement at https://cla.futo.org

@futo-cla-pr-labler
Copy link

Please sign our contributor license agreement at https://cla.futo.org

1 similar comment
@futo-cla-pr-labler
Copy link

Please sign our contributor license agreement at https://cla.futo.org

@Cederick
Copy link

Cederick commented Dec 12, 2024

I'm seeing multiple issues with the updated translation but I don't know how to suggest changes in the GitHub way.

At first I'd argue that cast should not be translated and does not need to be translated because the two protocols to cast are universally called fcast and Google cast everywhere in the world so it is more used as a name of a function then a descriptior.

I'd also argue that

31 Ein Update ist verfügbar, möchten Sie aktualisieren?

Is still wrong and just looks like Google translator was being used because it's that unnatural and not grammatical correct. This is not the only suggested change that either feels unnatural, uses improper grammar or has the wrong tone. Some have even multiple issues that should be correct or could need some tweaking. Using formal speech to inform about an update is something that is not needed and not really common in other entertainment software.

My suggestion for line 31 would be:

Ein Update ist verfügbar, möchten sie es jetzt anwenden?

This would be more in line with the English counterpart while obliging German grammar and a neutral tone.

This comment is in no way ment to discredit the fact that someone has put time and effort into improving FOSS nor is it ment as an attack.

Edit: Revised wording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants