-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kotlin to 2.0.0 #576
Bump Kotlin to 2.0.0 #576
Conversation
This PR is an attempt to bump the kotlin version to 2.0.0 and ultimately start making myself familiar with the codebase as I would be interested in supporting the project. That being said, I am noticing an issue with theseAdditionalWorkspaceTest.kt and ClassPathTest.kt test class methods not passing right now, but I created the PR anyway to spark the discussion. There seems to be an issue resolving junit in the classpath, so hovering over the I packaged the server after the update and instantiated it from Neovim, and it seems that it works, but the hovering over Any thought or pointers on where to start looking to resolve this issue? Tests output: AdditionalWorkspaceTest > junit should be on classpath FAILED
java.lang.AssertionError:
Expected: a string containing "fun assertTrue"
but: was "```kotlin
null
```"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at org.junit.Assert.assertThat(Assert.java:832)
at org.javacs.kt.AdditionalWorkspaceTest.junit should be on classpath(AdditionalWorkspaceTest.kt:31)
ClassPathTest > find gradle classpath FAILED
java.lang.AssertionError:
Expected: a collection containing a string containing "junit"
but: was "ClassPathEntry(compiledJar=~/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib/1.9.22/kotlin-stdlib-1.9.22.jar, sourceJar=null)"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at org.junit.Assert.assertThat(Assert.java:832)
at org.javacs.kt.ClassPathTest.find gradle classpath(ClassPathTest.kt:28) |
Thanks for looking into this, very much appreciated! It would be nice if you could split out the refactorings/cleanups into smaller commits for easier reviewability. Regarding the failing test, you could try running |
Hey! Thanks for the reply. I do have bumped it here. I removed all other changes for now that are not related with the version bump. |
@fwcd Sorry for pinging you, can you take a look when you have some time? |
de3d15c
to
b490bce
Compare
Closing this PR, opened a new one to bump version to 2.0.10. |
2.0.0
to the related Gradle files