Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lief to shrinkwrap and remove patchelf #2

Merged
merged 10 commits into from
Dec 24, 2021
Merged

Add lief to shrinkwrap and remove patchelf #2

merged 10 commits into from
Dec 24, 2021

Conversation

fzakaria
Copy link
Owner

@fzakaria fzakaria commented Dec 24, 2021

Add the necessary scaffolding to add lief as a dependency.

  • swap out some of the patchelf functionality for native cpython integration via lief
  • remove coreutils since now we don't rely on bin/cp for copy (that was egregious)
  • improve the poetry2nix setup after scouring GitHub for examples (Thank you @lovesegfault)
  • add flake checks to make the CI process simpler and more robust
  • remove patchelf

@fzakaria
Copy link
Owner Author

CC @trws

@fzakaria fzakaria changed the title Add lief to shrinkwrap Add lief to shrinkwrap and remove patchelf Dec 24, 2021
@fzakaria
Copy link
Owner Author

Don't inspect you to review -- it's a big PR. I'll keep it here for a bit before merging.

@trws
Copy link
Collaborator

trws commented Dec 24, 2021

LGTM, lot of changes but they're all coherent and look good.

@fzakaria fzakaria merged commit dbea132 into main Dec 24, 2021
@fzakaria fzakaria deleted the lief branch December 24, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants