Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glm/detail/type_half.inl contains non-utf8 space character. #196

Closed
gwk opened this issue Apr 29, 2014 · 1 comment
Closed

glm/detail/type_half.inl contains non-utf8 space character. #196

gwk opened this issue Apr 29, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@gwk
Copy link

gwk commented Apr 29, 2014

I ran a lint script on my source tree and it choked on an 0xad byte in the comment.

namespace glm{
namespace detail
{
    GLM_FUNC_QUALIFIER float overflow()
    {
        volatile float f = 1e10;

        for(int i = 0; i < 10; ++i) 
            f *= f;             // this will overflow before
!!INVALID-UTF8: b'\t\t\t\t\t\t\t\t// the for\xadloop terminates\r\n'
@gwk gwk changed the title include/glm/detail/type_half.inl contains non-utf8 space character. glm/detail/type_half.inl contains non-utf8 space character. Apr 30, 2014
@Groovounet Groovounet added the bug label May 4, 2014
Groovounet pushed a commit that referenced this issue May 4, 2014
@Groovounet Groovounet added this to the GLM 0.9.5 milestone May 4, 2014
@Groovounet Groovounet self-assigned this May 4, 2014
@Groovounet
Copy link
Member

This issue is fixed in GLM 0.9.5 branch for GLM 0.9.5.4 release.

Thanks for contributing,
Christophe

Groovounet pushed a commit that referenced this issue May 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants