0.9.9.3 is not backwards compatible?

[flaviut]

I'm unable to build Kicad with 0.9.9.3 due to the following error:

In file included from /usr/include/glm/detail/type_vec3.hpp:431,
                 from /usr/include/glm/ext/vector_bool3.hpp:5,
                 from /usr/include/glm/vec3.hpp:5,
                 from /usr/include/glm/glm.hpp:117,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/include/plugins/3dapi/xv3d_types.h:38,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_viewer/../3d_canvas/../3d_rendering/3d_render_raytracing/accelerators/../shapes2D/../ray.h:33,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_viewer/../3d_canvas/../3d_rendering/3d_render_raytracing/accelerators/../shapes2D/cbbox2d.h:33,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_viewer/../3d_canvas/../3d_rendering/3d_render_raytracing/accelerators/../shapes2D/cobject2d.h:33,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_viewer/../3d_canvas/../3d_rendering/3d_render_raytracing/accelerators/ccontainer2d.h:33,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_viewer/../3d_canvas/cinfo3d_visu.h:34,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_viewer/eda_3d_viewer.h:36,
                 from /home/user/dev/co/kicad/trunk/src/kicad-5.0.1/pcbnew/pcb_base_frame.cpp:42:
/usr/include/glm/detail/type_vec3.inl: In instantiation of ‘constexpr glm::vec<3, T, Q>& glm::vec<3, T, Q>::operator=(const glm::vec<3, T, Q>&) const [with T = float; glm::qualifier Q = (glm::qualifier)0]’:
/home/user/dev/co/kicad/trunk/src/kicad-5.0.1/common/../3d-viewer/3d_rendering/3d_render_raytracing/clight.h:91:43:   required from here
/usr/include/glm/detail/type_vec3.inl:205:12: error: assignment of member ‘glm::vec<3, float, (glm::qualifier)0>::<unnamed union>::x’ in read-only object
    this->x = v.x;
    ~~~~~~~~^~~~~
/usr/include/glm/detail/type_vec3.inl:206:12: error: assignment of member ‘glm::vec<3, float, (glm::qualifier)0>::<unnamed union>::y’ in read-only object
    this->y = v.y;
    ~~~~~~~~^~~~~
/usr/include/glm/detail/type_vec3.inl:207:12: error: assignment of member ‘glm::vec<3, float, (glm::qualifier)0>::<unnamed union>::z’ in read-only object
    this->z = v.z;
    ~~~~~~~~^~~~~
/usr/include/glm/detail/type_vec3.inl:208:12: error: binding reference of type ‘glm::vec<3, float, (glm::qualifier)0>&’ to ‘const glm::vec<3, float, (glm::qualifier)0>’ discards qualifiers
    return *this;
            ^~~~
/usr/include/glm/detail/type_vec3.inl:209:3: error: body of ‘constexpr’ function ‘constexpr glm::vec<3, T, Q>& glm::vec<3, T, Q>::operator=(const glm::vec<3, T, Q>&) const [with T = float; glm::qualifier Q = (glm::qualifier)0]’ not a return-statement
   }
   ^

0.9.9.2 works great though. Here is the offending code in kicad, which to my inexperienced eye looks OK, since the thing being assigned to is not const or readonly.

typedef glm::vec3       SFVEC3F;
...
    void GetLightParameters( const SFVEC3F &aHitPoint,
                             SFVEC3F &aOutVectorToLight,
                             SFVEC3F &aOutLightColor,
                             float &aOutDistance ) const override
    {
        const SFVEC3F vectorLight = m_position - aHitPoint;

        aOutDistance = glm::length( vectorLight );
        aOutVectorToLight = vectorLight / aOutDistance; // <- error here

[sethhillbrand]

See #832

[flaviut]

Dupe of #832