Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for android build issue. #217

Closed
wants to merge 2 commits into from

Conversation

blitz-research
Copy link

My first attempt at a pull request!

With this fix you no longer have to #define GLM_FORCE_CXX98 to be able to build on android.

@Groovounet
Copy link
Member

I think I see the issue. I have pushed an alternative fix using _nextafterf instead of _nextafter.

I expected that _nextafter will be for double and _nextafterf for float hence _nextafter could build but it would not work.

0.9.5 branch contain the fix now and you can try it out here: https://github.com/g-truc/glm/archive/0.9.5.zip

Thanks,
Christophe

@Groovounet Groovounet closed this Jun 28, 2014
@Groovounet Groovounet added the bug label Jun 28, 2014
@Groovounet Groovounet added this to the GLM 0.9.5 milestone Jun 28, 2014
@Groovounet Groovounet self-assigned this Jun 28, 2014
@blitz-research
Copy link
Author

Umm, still no go.

I searched through the android ndk r9d platform-19 *.h files and there
doesn't appear to be a _nextafterf.

There is, however, __builtin_nextafterf, and replacing your _nextafterf's
with this appears to work. Well, my game compiles and doesn't crash at
least...not sure what this is even used for!

On Sun, Jun 29, 2014 at 7:00 AM, Christophe Riccio <[email protected]

wrote:

Closed #217 #217.


Reply to this email directly or view it on GitHub
#217 (comment).

@Groovounet
Copy link
Member

Ahhhhh! Android "standard" library is a bitch.

I'll update with __builtin_nextafterf.

This is used for ULP calculation if you need to get some input about the accuracy of some operations.

Probably, you don't actually need it.

Thanks!

@Groovounet Groovounet reopened this Jun 29, 2014
Groovounet added a commit that referenced this pull request Sep 1, 2014
@Groovounet
Copy link
Member

This issue should be fixed in GLM 0.9.5 branch.

Thanks for contributing,
Christophe

@Groovounet Groovounet closed this Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants