Update container component to accept args as Iterable and Mapping #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Here are some examples: | ||
| docker.create('ubuntu', ['ls']) | ||
| docker.create('ubuntu', ['cat', '/some/file.txt']) | ||
| You can try docker.create('{image}', {shlex.split(command)}, ...). |
There was a problem hiding this comment.
Thank you for this error message. This is so, so awesome. Would it be possible in another PR to add a unit tests for this? Something that checks that docker.create('{image}', {shlex.split(command)} appears correctly in the error message.
There was a problem hiding this comment.
This was just copied (and simplified) from the run() method!
gabrieldemarmiesse
merged commit 6ac7b6f
into
gabrieldemarmiesse:master
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #595 and #599, working on #584.