Fix importing language definition with dependencies #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugin seems to fail with when the language syntax used has a dependency (its Prism definition extends another syntax), such as C++ that extends C, the plugin fails to load the syntax because it does not load its dependencies.
This PR requires at startup a "prelude" of syntax definitions, the few ones that are extended. It allows to use syntax such as
cpp,java,go...An alternative is to require dependencies dynamically. But this is not straight feasible, since Prism does not export the components dependencies list.
Related #16