Skip to content

Commit

Permalink
Add environment-specific importing for index.js
Browse files Browse the repository at this point in the history
This removes a few of the error messages that are only applicable in
development, which saves a few bytes in production builds.
  • Loading branch information
calesce committed Nov 28, 2016
1 parent d360e3a commit 51dae3f
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 37 deletions.
39 changes: 39 additions & 0 deletions src/index.dev.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use strict';

const AppContainer = require('./AppContainer');

module.exports = function warnAboutIncorrectUsage(arg) {
if (this && this.callback) {
throw new Error(
'React Hot Loader: The Webpack loader is now exported separately. ' +
'If you use Babel, we recommend that you remove "react-hot-loader" ' +
'from the "loaders" section of your Webpack configuration altogether, ' +
'and instead add "react-hot-loader/babel" to the "plugins" section ' +
'of your .babelrc file. ' +
'If you prefer not to use Babel, replace "react-hot-loader" or ' +
'"react-hot" with "react-hot-loader/webpack" in the "loaders" section ' +
'of your Webpack configuration.'
);
} else if (arg && arg.types && arg.types.IfStatement) {
throw new Error(
'React Hot Loader: The Babel plugin is exported separately. ' +
'Replace "react-hot-loader" with "react-hot-loader/babel" ' +
'in the "plugins" section of your .babelrc file. ' +
'While we recommend the above, if you prefer not to use Babel, ' +
'you may remove "react-hot-loader" from the "plugins" section of ' +
'your .babelrc file altogether, and instead add ' +
'"react-hot-loader/webpack" to the "loaders" section of your Webpack ' +
'configuration.'
);
} else {
throw new Error(
'React Hot Loader does not have a default export. ' +
'If you use the import statement, make sure to include the ' +
'curly braces: import { AppContainer } from "react-hot-loader". ' +
'If you use CommonJS, make sure to read the named export: ' +
'require("react-hot-loader").AppContainer.'
);
}
};

module.exports.AppContainer = AppContainer;
44 changes: 7 additions & 37 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,39 +1,9 @@
'use strict';

const AppContainer = require('./AppContainer');
/* eslint-disable global-require */

module.exports = function warnAboutIncorrectUsage(arg) {
if (this && this.callback) {
throw new Error(
'React Hot Loader: The Webpack loader is now exported separately. ' +
'If you use Babel, we recommend that you remove "react-hot-loader" ' +
'from the "loaders" section of your Webpack configuration altogether, ' +
'and instead add "react-hot-loader/babel" to the "plugins" section ' +
'of your .babelrc file. ' +
'If you prefer not to use Babel, replace "react-hot-loader" or ' +
'"react-hot" with "react-hot-loader/webpack" in the "loaders" section ' +
'of your Webpack configuration.'
);
} else if (arg && arg.types && arg.types.IfStatement) {
throw new Error(
'React Hot Loader: The Babel plugin is exported separately. ' +
'Replace "react-hot-loader" with "react-hot-loader/babel" ' +
'in the "plugins" section of your .babelrc file. ' +
'While we recommend the above, if you prefer not to use Babel, ' +
'you may remove "react-hot-loader" from the "plugins" section of ' +
'your .babelrc file altogether, and instead add ' +
'"react-hot-loader/webpack" to the "loaders" section of your Webpack ' +
'configuration.'
);
} else {
throw new Error(
'React Hot Loader does not have a default export. ' +
'If you use the import statement, make sure to include the ' +
'curly braces: import { AppContainer } from "react-hot-loader". ' +
'If you use CommonJS, make sure to read the named export: ' +
'require("react-hot-loader").AppContainer.'
);
}
};
'use strict';

module.exports.AppContainer = AppContainer;
if (!module.hot || process.env.NODE_ENV === 'production') {
module.exports = require('./index.prod');
} else {
module.exports = require('./index.dev');
}
3 changes: 3 additions & 0 deletions src/index.prod.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict';

module.exports.AppContainer = require('./AppContainer');

0 comments on commit 51dae3f

Please sign in to comment.