React Hot Loader 3

[gaearon]

Work in progress.
(We are skipping 2 because the approach is way too different from 2 alpha which went nowhere).

Some info here: gaearon/react-hot-boilerplate#61

[ntucker]

Whenever I change a module, the console logs say it's updated, but nothing changes. I did some tracking on module updates:

• Changed module is being executed
• Component render function is being run
• However, the module code is still old (changing the console.log message doesn't get reflected).

Is webpack somehow not actually updating the code, but just re-executing the existing modules? (I'm using webpack 1.14.0)

[dobryanskyy]

@ntucker were you able to solve the issue? I'm experiencing quite similar one

[ntucker]

@dobryanskyy nope, still broken.

[rolandfung]

I have multiple applications in the same repo, so I use a wrapper function that takes in the root element, store and controller as the parameters (I'm using Cerebral.js). Changes in application files are being detected but I get full reload each time in the browser. Is my usage of this wrapper causing the problem? I am on RHL3 beta 6 and webpack 1.13.2.

let getAppWrapper = (App, controller, store) => {
    @root(store)
    class AppWrapper extends React.Component {
        render() {
            return (
                <Container controller={controller}>
                    <MuiThemeProvider>
                        <App {...this.props}>
                            {this.props.children}
                        </App>
                    </MuiThemeProvider>
                </Container>
            );
        }
    }
    return AppWrapper;
};

[ismay]

@rolandfung I'm experiencing the same problem (full reload on changes), with hot-loader beta6 and webpack 2.2.0:

// abstract render for hot reloading
const renderWithHotReload = AppComponent => {
  render(
    <AppContainer>
      <AppComponent store={store} />
    </AppContainer>,
    document.getElementById('app')
  )
}

// initial render
renderWithHotReload(App)

// enable hot reloading, will be stripped in production
if (process.env.NODE_ENV !== 'production' && module.hot) {
  module.hot.accept('./components/app', () => {
    const NextApp = require('./components/app').App
    renderWithHotReload(NextApp)
  })
  module.hot.accept('./rootReducer', () => {
    const nextRootReducer = require('./rootReducer').default
    store.replaceReducer(nextRootReducer)
  })
}

Code here. Apologies if this isn't the place to post this (but thought it would be valuable in case it's a bug).

[SimenB]

Woo! 🎉

[wkwiatek]

Just to keep you up-to-date.

We're now finalizing docs, and have 3 more bugs to solve that are blockers for final release. All of these are on the behalf of react-proxy.

We agreed to merge next to the master as some people had problem with starting with React Hot Loader, and v1 is now stale.

[SimenB]

React-proxy hasn't seen a commit in 11 months, will it be getting some love?
And could you link to the outstanding issues?

[wkwiatek]

Here are all of them: https://github.com/gaearon/react-hot-loader/milestone/2

I'm going to focus on the react-proxy right after RHL v3 docs are done.