Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the import of a component from a component with the same base name #347

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Fix the import of a component from a component with the same base name #347

merged 1 commit into from
Sep 14, 2016

Conversation

tanguylebarzic
Copy link
Contributor

Fix #337, without accessing internal webpack variables.

@calesce
Copy link
Collaborator

calesce commented Sep 14, 2016

Cool, I played around with this, and it works in a few simple cases. I'd prefer to have this kind of stuff tested, but we don't have tests on the Webpack loader anyways (something to improve!).

Either way, since #337 was directly affecting at least a few people, and I don't see how it can break other use cases, I'll go ahead and merge it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants