(1.3) Fix ReactMount import for React 15.4 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep supporting pre-15.4 by using a try-catch and adding the correct import statement based on whether importing it from react-dom (the new way) fails.
calesce
changed the title
flyskywhy
added a commit
to flyskywhy/react-web
that referenced
this pull request
Mar 14, 2017
… 'react/lib/ReactMount'` ref to gaearon/react-hot-loader#430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Note: this is a breakfix because this broke a many people's apps and will probably be the last 1.x fix.
This will still support pre-15.4 by using a try-catch and adding the correct
import statement based on whether importing it from
react-dom(the newway) fails.
I've tested this with React 15.4, 15.3, and 0.14.