Double proxy registration. Fix regression #912 #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theKashey
commented
Mar 30, 2018
| const proxy = { get, update } | ||
| proxy = { get, update } | ||
|
|
||
| proxies.set(InitialComponent, proxy) |
There was a problem hiding this comment.
This is actually a fix. Everything else is related to this change - now tests have "reset" proxies sometimes.
theKashey
commented
Mar 30, 2018
| expect(spy).not.toHaveBeenCalled() | ||
| RHL.register(App, 'App3', 'test.js') | ||
| wrapper.setProps({ children: <App /> }) | ||
| expect(spy).not.toHaveBeenCalled() |
There was a problem hiding this comment.
It will stop here. It is still the App, but that App will use ProxyComponent created for App3
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=========================================
+ Coverage 87.42% 87.5% +0.07%
=========================================
Files 30 30
Lines 636 640 +4
Branches 149 149
=========================================
+ Hits 556 560 +4
Misses 64 64
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#912 - Super nasty bug :(, @leandrorlemos - kudos for reporting.
Could break all the things in case of code splitting - something "old" could be "registered" by a new name (it is just a variable name), obtain a new proxy and unmount old instances.
Was fixed in v3. We broke it during migration, and had no tests around it.