fix(action)!: Fix preserve-block-position default

[bmaximuml]

Current logic adds --preserve-block-position to list of args if the length of the value provided to the preserve-block-position github actions variable is not zero. Since it defaults to the string false, this effectively defaults it to true. You can only disable it by setting it explicitly to an empty string. This PR corrects this logic by only enabling preserve-block-position if it's explicitly set to true.

BREAKING CHANGE: Effectively change default value for preserve-block-position in github actions

[bmaximuml]

@gagoar please could you take a look at this?

[coveralls]

Pull Request Test Coverage Report for Build 7412441122

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 6989677130:	0.0%
Covered Lines:	263
Relevant Lines:	263

---

💛 - Coveralls

[gagoar]

@bmaximuml Thanks for this; I will release the action and the other PR on Friday.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91bab21) 100.00% compared to head (236fa43) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #393   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          284       284           
  Branches        64        64           
=========================================
  Hits           284       284           

Flag	Coverage Δ
unittests	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmaximuml]

Fantastic! Thanks @gagoar

[gagoar]

Fantastic! Thanks @gagoar

thank you @bmaximuml ❤️ and sorry for the delay.

[gustavkj]

@gagoar Since the Github Action still is release manually, I'm not sure if this should be marked as breaking since that will only cause the npm library to update to a new major version. 🤔

[gagoar]

@gagoar Since the Github Action still is release manually, I'm not sure if this should be marked as breaking since that will only cause the npm library to update to a new major version. 🤔

Yea. What I would do is:

• @gustavkj go ahead and release with all the new and ready functionality like you have done in the past.
• I will jump a version in the action manually to show the breaking change.
• I will create the app as suggested in ci: use github app for release-please permissions #396
  Does that sounds like a plan to you?

[gustavkj]

I've released the changes now by merging the release-please PR (I had to push a commit of my own to it to make the workflows run).

Another option to the versioning would be to use the same version numbers. The drawback is that breaking changes to either would result in a major version bump.

[gagoar]

I've released the changes now by merging the release-please PR (I had to push a commit of my own to it to make the workflows run).

Another option to the versioning would be to use the same version numbers. The drawback is that breaking changes to either would result in a major version bump.

I chose not to do that when I started with the action. The reason is the nature of the code:

• The action advances only when the CLI changes. I can even make that more automatic in the future.
• The library might have bugs or improvements unrelated to the CLI.

[gagoar]

hey @bmaximuml here's the release https://github.com/gagoar/codeowners-generator/releases/tag/action.v2.0

thanks for your help!