Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action)!: Fix preserve-block-position default #393

Merged
merged 1 commit into from
Jan 15, 2024

Commits on Jan 4, 2024

  1. fix(action)!: Fix preserve-block-position default

    Current logic adds `--preserve-block-position` to list of args if the length of
    the value provided to the `preserve-block-position` github actions variable is
    not zero. Since it defaults to the string `false`, this effectively defaults it
    to true. You can only disable it by setting it explicitly to an empty string.
    This PR corrects this logic by only enabling `preserve-block-position` if it's
    explicitly set to true.
    
    BREAKING CHANGE: Effectively change default value for preserve-block-position
    in github actions
    bmaximuml committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    236fa43 View commit details
    Browse the repository at this point in the history