feat: FiveM #222
Merged
feat: FiveM #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
protocol
|
I have no idea whether to separate info and players or to keep them together but this works for now. |
|
Approving workflow to run checks |
cainthebest
requested changes
Sep 22, 2024
There was a problem hiding this comment.
This is starting to look good, ty for the pr.
There are some things that need doing before this can pass the CI.
- Format the code to fmt spec with the nightly formatter
- Add the example to the lib cargo with required features
Once this passes CI i will find the time for a full review, thanks again
|
What happened here? Pull bot? |
|
Sorry, will have a look at this sometime in the future, dont know when this becomes relevant for me again. I was struggling with rustfmt giving me very weird formatting suggestions so I just gave up 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.