-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure and clean up of make.py #177
Comments
How about adding the files from |
Do you want to copy the input/sources files to docs/data as well? |
Yes. It should be scripted in the same way as SED and LC: there should be a class that processes it. It can start out mostly empty, i.e. making a copy, but then over time we'll add scripted fixes and additions before writing out the file, to make the output as uniform as possible. |
After working a little bit on this IMO one should change point 1) and point 2) in the upper procedure. Because if there is already a input index file it will be easy to scan through its entries and check them against the schemas. Hence, the new procedure is: 1) input-index-file 2) check-input 3) catalog 4) check-catalog 5) collection 6) check-collection 7) collection-index-file 8) webpage |
'make.py all' is doing a lot of things which need a bit clean up and restructuring.
I start with a description of the new structure followed by a description of necessary clean up later on.
The following list describes the future cli-commands of make.py and a description of them (make.py all' should execute them chronologically):
1) check-input
Basically the same as 'make.py checks --step input'. The info.yaml files and their validation should be added to the InputData class in a clean way.
2) input-index-file
Basically the same as 'make.py collection --step input-index' which creates the index file of all input data. See #175 for more details about that file.
3) catalog
Basically the same as 'make.py catalog' which produces the catalog fits-, yaml- and ecsv-file
4) check-catalog
Basically the same as 'make.py checks --step catalog' which validates the three catalog files from step 3).
5) collection
Basically the same as 'make.py collection --step [sed, lightcurve, lc]' which copies all data from the input folder to $GAMMACAT/docs/data.
6) check-collection
Basically the same as 'make.py checks --step collection' which validates the data files of the collection which are produced in step 5).
7) collection-index-file
Basically the same as 'make.py collection --step output-index' which creates the index file of all data in $GAMMACAT/docs/data/data.
7) webpage
Basically 'make.py webpage' which is under development. See
One can think about joining some of the upper steps but this can be done very easily at the end.
Moreover, there has to be done a clean up in the procedure of these steps.
In easy words: The start of step 3) and 5) should be the input-index file and not a scan through the corresponding folder.
The text was updated successfully, but these errors were encountered: