Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src info to output #179

Merged
merged 3 commits into from
Dec 11, 2017
Merged

Src info to output #179

merged 3 commits into from
Dec 11, 2017

Conversation

pdeiml
Copy link
Collaborator

@pdeiml pdeiml commented Nov 30, 2017

This PR adds all basic source info files which are stored in $GAMMACAT/input/sources to the output collection, more precisely, to $GAMMACAT/docs/data/sources.
See comment of @cdeil here:
#177 (comment)

Ready to merge (but look at the inline comment!)

@cdeil
Copy link
Contributor

cdeil commented Dec 11, 2017

This looks good, except for one issue: the reference_id isn't filled with something useful, it's a string serialisation of a Python list:

    {
        "source_id": 3,
        "reference_id": "['2017ApJ...836...23A', '2011ApJ...730L..20A']",
        "file_id": -1,
        "type": "bsi",
        "location": "sources/tev-000003.yaml"
    },
    {
        "source_id": 4,
        "reference_id": "['2012AIPC.1505..490B']",
        "file_id": -1,
        "type": "bsi",
        "location": "sources/tev-000004.yaml"
    },

Fixed in 1b07ab6.

@cdeil cdeil merged commit f4c82e9 into gammapy:master Dec 11, 2017
@pdeiml pdeiml deleted the src_info_to_output branch December 11, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants