-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change spectral model input format #119
Conversation
I'm merging this now. And I'll do a follow-up PR changing the spectral model parameter output format in the catalog. The diff here is reasonable, although there's ~ 7 PL2 spectra where some values in the output catalog were lost, because of emin / emax handling. The previous results were possibly incorrect anyways, and this should be fixed later today when the catalog output format is changed. |
I'm changing the spectral model input format in this pull request:
The goal is to get rid of the data entry issues we had for PL2 and ECPL models by having a more clear / explicit data entry scheme.
This is possibly a format we could support in Gammapy via the generic
to_dict
/from_dict
methods (but I don't have time to work on that today).