Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spectral model input format #119

Merged
merged 13 commits into from
May 12, 2017
Merged

Change spectral model input format #119

merged 13 commits into from
May 12, 2017

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented May 11, 2017

I'm changing the spectral model input format in this pull request:

  • Adapt all input YAML files
  • Adapt the schema
  • Adapt the scripts

The goal is to get rid of the data entry issues we had for PL2 and ECPL models by having a more clear / explicit data entry scheme.

This is possibly a format we could support in Gammapy via the generic to_dict / from_dict methods (but I don't have time to work on that today).

@cdeil cdeil added this to the 0.1 milestone May 11, 2017
@cdeil cdeil self-assigned this May 11, 2017
@cdeil
Copy link
Contributor Author

cdeil commented May 12, 2017

I'm merging this now. And I'll do a follow-up PR changing the spectral model parameter output format in the catalog.

The diff here is reasonable, although there's ~ 7 PL2 spectra where some values in the output catalog were lost, because of emin / emax handling. The previous results were possibly incorrect anyways, and this should be fixed later today when the catalog output format is changed.
We can use spectral plots to compare against flux points to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant