Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for non-ascii characters in docs #671

Merged
merged 2 commits into from
Nov 13, 2023
Merged

check for non-ascii characters in docs #671

merged 2 commits into from
Nov 13, 2023

Conversation

GernotMaier
Copy link
Contributor

Deployment of github pages fails with non-ascii characters in the rst files (see #669)

Add a workflow step to check RST files and exit if there are non-ascii characters.

@GernotMaier GernotMaier self-assigned this Nov 10, 2023
@GernotMaier GernotMaier marked this pull request as ready for review November 10, 2023 11:04
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #671 (1fa15a6) into main (afaa144) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          39       39           
  Lines        3551     3551           
=======================================
  Hits         3526     3526           
  Misses         25       25           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@VictorBarbosaMartins
Copy link
Contributor

Hi Gernot. As I do not know where to check to see whether the workflow is working, could you please provide more information in the PR?

@GernotMaier
Copy link
Contributor Author

See the test here: https://github.com/gammasim/simtools/actions/runs/6823947507/job/18558879126

I have put non-ascii characters into one rst file and the code works as expected.

Copy link
Contributor

@VictorBarbosaMartins VictorBarbosaMartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks! then this is very good.

@GernotMaier GernotMaier merged commit 6b33f34 into main Nov 13, 2023
13 checks passed
@GernotMaier GernotMaier deleted the check-unicode branch November 13, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants