Layout array renaming #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 81.93% 81.93%
=======================================
Files 40 40
Lines 6127 6127
=======================================
Hits 5020 5020
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
GernotMaier
added
the
Less than 15-min Pull Request Review
orelgueta
reviewed
Nov 29, 2023
rnda-docker.sh
Outdated
There was a problem hiding this comment.
Should this file be included in this PR (or in general)?
rnda.sh
Outdated
There was a problem hiding this comment.
Should this file be included in this PR (or in general)?
|
Also, there are conflicts apparently, probably cause it took me so long to review this PR... |
|
Fixed both things - remove the accidentally committed shell scripts and merged main into this branch. |
orelgueta
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #428 to change the term
LayoutArraytoArrayLayoutthrough the code (alsolayout_arraytoarray_layout).There is zero functional change, this is search and replace only. So I think that no code review is required (as long as all tests pass).