-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve startup time of applications #682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 39 40 +1
Lines 3573 3575 +2
=======================================
+ Hits 3548 3550 +2
Misses 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates, it is improving also in the direction of #665.
I left only one comment/suggestion.
simtools/io_operations/io_hdf5.py
Outdated
_logger = logging.getLogger(__name__) | ||
|
||
|
||
def fill_hdf5_table(hist, x_bin_edges, y_bin_edges, x_label, y_label, meta_data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to have all the hdf5 functions together, but this function is not actually an io as it does not deal with input and output. Instead, if fills the table. Maybe we should call the module hdf5_handler
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this is a good suggestion. I've renamed io_hdf5
to hd5_handler
.
Waiting for the tests and will merge when successful.
Applications are very slow in starting up, see issue #681 .
This is mostly related to imports and this pull request is start to optimize this:
This improves the speed of calling e.g.,
python simtools/applications/validate_schema_files.py --help
by a factor of 4!