-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests of simtools-prod containers #713
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 82.18% 82.22% +0.04%
==========================================
Files 42 41 -1
Lines 6196 6210 +14
==========================================
+ Hits 5092 5106 +14
Misses 1104 1104 ☔ View full report in Codecov by Sentry. |
And I notice now that the docker-simtools test start when pressing "read for review". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using the config file that comes in tests/resources
for running, but do we expect that the production container comes with the tests
directory? It probably shouldn't, no?
If we decide to remove tests
from this container, we can just provide the arguments directly, they are not too many.
I approve anyway cause the solution works for now.
(As a side note, the amount of commits and their messages for such a small change show how much of a pain it is to work on docker stuff.)
No, the |
Oh yea, I forgot this is part of building the container and therefore we need to checkout simtools anyway. All good then. |
Add a test for the simtools-prod container to ensure that everything is correctly installed. For this, run a single application test using the database and sim_telarray (
simtools-simulate-prod
).This required to separate the steps of generating the container and pushing.
The successful github action workflow for the container generation do not appear below, it is: