Base64 update #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g replacement with decodebytes
|
Please merge |
|
@gammazero could you please merge this change? |
gammazero
approved these changes
Oct 15, 2024
| if sys.version_info >= (3, 1) : | ||
| fp.write(base64.decodebytes(PKG_DATA)) | ||
| else : | ||
| fp.write(base64.decodestring(PKG_DATA)) |
There was a problem hiding this comment.
Probably do not need to support this anymore
|
Hi Andrew,
sorry I gave a try to the release and found out retrocompatibility for
python < 3.12 has been broken, can you have a look?
#18
Il giorno mar 15 ott 2024 alle ore 12:17 Andrew Gillis <
***@***.***> ha scritto:
… Merged #9 <#9> into master.
—
Reply to this email directly, view it on GitHub
<#9 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2XDU7E2M5YMK5ICVK5CPU3Z3TTUBAVCNFSM6AAAAABP6YW25GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY2TIOBRGA4DONI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
This PR is required to allow pymakeself to work with Python post 3.9...
The current version of pymakeself makes use of the depreciated base64.decodestring method which was removed in Python 3.9.
This PR adds a check for python version, and if the version is later than 3.1 it uses the base54.decodebytes method.
(I have tested this on my own archive using my "merged_main" branch.)
Thanks for a very useful tool!